Instrument Google Cloud Storage client #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
September 23, 2020 12:08
The library has dropped support for Python 2
andrewslotin
force-pushed
the
instrument_gcs
branch
from
1bcd313 to
36f5bba
Compare
pglombardo
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds instrumentation for
google-cloud-storageclient by wrapping thegoogle.cloud.storage._http.Connection.api_request()and extracting span data from the request made to Google Cloud Storage JSON API.Since
storage.Clientdoes not use this API to upload and download blobs, additional wrappers are needed to instrumentstorage.blob.Blob.{upload,download}_*calls.Batches are implemented as a wrapper for
storage._http.Connectionand thus also needed a special handling.